Re: Replica Identity check of partition table on subscriber

On Tue, Jun 21, 2022 at 7:49 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> On Mon, Jun 20, 2022 at 3:46 PM shiy(dot)fnst(at)fujitsu(dot)com
> <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
> > On Mon, Jun 20, 2022 1:33 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > One minor comment:
> > > + /*
> > > + * If it is a partitioned table, we don't check it, we will check its
> > > + * partition later.
> > > + */
> > >
> > > Can we change the above comment to: "For partitioned tables, we only
> > > need to care if the target partition is updatable (aka has PK or RI
> > > defined for it)."?
> > >
> > Thanks for your comment. Modified in the attached patches.
>
> How about: ...target "leaf" partition is updatable
>

I am not very sure if this is an improvement over the current.

> Regarding the commit message's top line, which is this:
>
> Fix partition table's RI checking on the subscriber.
>
> I think it should spell out REPLICA IDENTITY explicitly to avoid the
> commit being confused to have to do with "Referential Integrity
> checking".
>

This makes sense. I'll take care of this.

--
With Regards,
Amit Kapila.