Re: Fix typos for v12

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix typos for v12
Date: 2019-05-26 13:49:34
Message-ID: CAA4eK1JhUy_ThWzH9gSXhuAo4=k8xJddsMLpPayrFeV-oQNH7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 25, 2019 at 8:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > I have taken one pass over it and all fixes seem to be correct and got
> > introduced in v12. I will re-verify them once again and then commit
> > your patch if I don't found any problem. In the meantime, if anyone
> > else wants to look at it, that would be great.
>
> FWIW, I'd counsel against applying the changes in imath.h/.c, as that
> is not our code, and unnecessary variations from upstream will just
> make it harder to track upstream.
>

This occurred to me as well while reviewing, but I thought typo fixes
should be fine. Anyway, I have excluded those before pushing. So, if
we want to fix these, then maybe one has to first get this fixed in
upstream first and then take from there.

> The rest of this looks fine.
>

Thanks, pushed.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2019-05-26 13:49:49 Re: This seems like very unfriendly behaviour
Previous Message Tatsuo Ishii 2019-05-26 12:53:41 vacuumdb as server application in v12 release note