Re: Decoding speculative insert with toast leaks memory

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: Decoding speculative insert with toast leaks memory
Date: 2021-06-01 04:23:40
Message-ID: CAA4eK1JcQ36FT0+iS9mEtx-s4Ss=c30Wb+5gAo1n6FHyf_qP6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 31, 2021 at 8:12 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Mon, May 31, 2021 at 6:32 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > I missed to do the test for streaming. I will to that tomorrow and reply back.
>
> For streaming transactions this issue is not there. Because this
> problem will only occur if the last change is *SPEC INSERT * and after
> that there is no other UPDATE/INSERT change because on that change we
> are resetting the toast table. Now, if the transaction has only *SPEC
> INSERT* without SPEC CONFIRM or any other INSERT/UPDATE then we will
> not stream it. And if we get any next INSERT/UPDATE then only we can
> select this for stream but in that case toast will be reset. So as of
> today for streaming mode we don't have this problem.
>

What if the next change is a different SPEC_INSERT
(REORDER_BUFFER_CHANGE_INTERNAL_SPEC_INSERT)? I think in that case we
will stream but won't free the toast memory.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-06-01 04:29:41 Re: Decoding speculative insert with toast leaks memory
Previous Message Justin Pryzby 2021-06-01 04:16:35 Re: AWS forcing PG upgrade from v9.6 a disaster