| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reviewing freeze map code |
| Date: | 2016-06-10 13:27:31 |
| Message-ID: | CAA4eK1JbsxWaT-ZL-CEe5PzFXGhM4hTXQN+2u2A0K3LA_ZQb0g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 10, 2016 at 12:09 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2016-06-10 11:58:26 +0530, Amit Kapila wrote:
>
>
> > While looking at code in this area, I observed that during replay of
> > records (heap_xlog_delete), we first clear the vm, then update the page.
> > So we don't have Buffer lock while updating the vm where as in the patch
> > (collect_corrupt_items()), we are relying on the fact that for clearing
vm
> > bit one needs to acquire buffer lock. Can that cause a problem?
>
> Unsetting a vm bit is always safe, right?
>
I think so, which means this should not be a problem area.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-06-10 13:32:54 | Re: [HACKERS] Online DW |
| Previous Message | Amit Kapila | 2016-06-10 13:22:26 | Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted |