| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Önder Kalacı <onderkalaci(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2023-03-01 08:40:07 |
| Message-ID: | CAA4eK1JZS8d8W2tRYht+mXM9FQp2GBSmP+avrDZWU4YgeepyQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 1, 2023 at 12:09 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > I see this as a way to provide this feature for users but I would
> > prefer to proceed with this if we can get some more buy-in from senior
> > community members (at least one more committer) and some user(s) if
> > possible. So, I once again request others to chime in and share their
> > opinion.
>
> I'd prefer not having an option, because we figure out the cause of the
> performance regression (reducing it to be small enough to not care). After
> that an option defaulting to using indexes.
>
Sure, if we can reduce regression to be small enough then we don't
need to keep the default as false, otherwise, also, we can consider it
to keep an option defaulting to using indexes depending on the
investigation for regression. Anyway, the main concern was whether it
is okay to have an option for this which I think we have an agreement
on, now I will continue my review.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2023-03-01 08:49:52 | Re: WIN32 pg_import_system_collations |
| Previous Message | Michael Paquier | 2023-03-01 08:15:56 | Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable() |