Inconsistency in Output function of MergeJoin

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Inconsistency in Output function of MergeJoin
Date: 2015-09-23 09:56:59
Message-ID: CAA4eK1JX+43hJe0VFOUPEoctUxZPB0aZGJx_s4RUNqkG+=710g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While working on read functions for plan nodes (required for
parallelism), it has been observed [1] by KaiGai and separately
by me that function _outMergeJoin(), appends boolean in a
slightly different way as compare to other out functions like
_outSort(). Is there a reason of doing so which is is not apparent
from code or comments?

Attached patch makes _outMergeJoin() consistent with other _out
functions which appends boolean to string.

[1] -
http://www.postgresql.org/message-id/9A28C8860F777E439AA12E8AEA7694F80114956C@BPXM15GP.gisp.nec.co.jp

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
fix_outMergeJoin_inconsistency_v1.patch application/octet-stream 486 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-09-23 10:22:48 Re: Parallel Seq Scan
Previous Message Shulgin, Oleksandr 2015-09-23 09:40:06 Re: Calculage avg. width when operator = is missing