| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add 'worker_type' to pg_stat_subscription |
| Date: | 2023-09-21 10:31:20 |
| Message-ID: | CAA4eK1JVyJwYm_WDM6_fFL0hBPWWt0Juv1j2npJNRJ1cVtLjGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 21, 2023 at 1:00 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Tue, Sep 19, 2023 at 08:36:35AM +0530, Amit Kapila wrote:
> > I am of the opinion that worker_type should be 'apply' instead of
> > 'leader apply' because even when it is a leader for parallel apply
> > worker, it could perform individual transactions apply. For reference,
> > I checked pg_stat_activity.backend_type, there is nothing called main
> > or leader backend even when the backend is involved in parallel query.
>
> Okay. Here is v9 of the patch with this change.
>
The changes looks good to me, though I haven't tested it. But feel
free to commit if you are fine with this patch.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-09-21 10:44:12 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Amit Kapila | 2023-09-21 10:25:37 | Re: Add 'worker_type' to pg_stat_subscription |