Re: pgsql: Document XLOG_INCLUDE_XID a little better

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better
Date: 2021-11-03 03:10:26
Message-ID: CAA4eK1JUrJQAVF9ABQg9r7ZNfZa1TD3xxnqRMcKwnGUUC9zgWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Oct 28, 2021 at 8:15 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Oct 27, 2021 at 4:39 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Tue, Oct 26, 2021 at 9:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > >
> > > > Thanks, both your patches look good to me except that we need to
> > > > remove the sentence related to the revert of ade24dab97 from the
> > > > commit message. I think we should backpatch the first patch to 14
> > > > where it was introduced and commit the second patch (related to moving
> > > > code out of critical section) only to HEAD but we can even backpatch
> > > > the second one till 9.6 for the sake of consistency. What do you guys
> > > > think?
> > > >
> > >
> > > The other option could be to just commit both these patches in HEAD as
> > > there is no correctness issue here.
> >
> > Right, even I feel we should just commit it to the HEAD as there is no
> > correctness issue.
> >
>
> Thanks for your opinion. I'll commit it to the HEAD by next Tuesday
> unless someone feels that we should backpatch this.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-11-03 06:38:12 pgsql: Fix incorrect format placeholder
Previous Message Peter Geoghegan 2021-11-03 02:53:08 pgsql: Fix parallel amvacuumcleanup safety bug.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2021-11-03 03:18:35 Re: should we enable log_checkpoints out of the box?
Previous Message Amit Kapila 2021-11-03 03:00:33 Re: Added schema level support for publication.