| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-03-25 11:45:32 |
| Message-ID: | CAA4eK1JRHFmnb8Nxzc2t81mEnpOD0zEz5M3WGunmA_mRvk9e_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 25, 2025 at 5:08 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> This looks mostly ready except the test changes. I believe when
> committing, we are going to squash all three into a single commit. Is
> that correct?
>
I would not prefer to commit 0003 as it is primarily because of test
+# run pg_createsubscriber with '--all' option without '--dry-run'. I
am not so sure whether it is really worth adding test cycles for this
option except for dry-run mode tests but we can discuss after
committing the core patch.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-03-25 11:47:03 | Re: CREATE DATABASE with filesystem cloning |
| Previous Message | Yura Sokolov | 2025-03-25 11:45:09 | Re: sinvaladt.c: remove msgnumLock, use atomic operations on maxMsgNum |