From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2021-03-22 12:50:54 |
Message-ID: | CAA4eK1JPEoYAkggmLqbdD+cF=kWNpLkZb_wJ8eqj0QD2AjBTBA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 22, 2021 at 2:41 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Mon, Mar 22, 2021 at 6:27 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> >
> > Hi Amit.
> >
> > PSA a small collection of feedback patches you can apply on top of the
> > patch v65-0001 if you decide they are OK.
> >
> > (There are all I have found after a first pass over all the recent changes).
> >
>
> I have spell-checked the content of v65-0001.
>
> PSA a couple more feedback patches to apply on top of v65-0001 if you
> decide they are ok.
>
I have incorporated all your changes and additionally made few more
changes (a) got rid of LogicalRepBeginPrepareData and instead used
LogicalRepPreparedTxnData, (b) made a number of changes in comments
and docs, (c) ran pgindent, (d) modified tests to use standard
wait_for_catch function and removed few tests to reduce the time and
to keep regression tests reliable.
--
With Regards,
Amit Kapila.
Attachment | Content-Type | Size |
---|---|---|
v66-0001-Add-support-for-prepared-transactions-to-built-i.patch | application/octet-stream | 102.6 KB |
v66-0002-Support-2PC-txn-subscriber-tests.patch | application/octet-stream | 21.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2021-03-22 12:52:47 | Re: proposal - psql - use pager for \watch command |
Previous Message | Peter Eisentraut | 2021-03-22 12:50:40 | Re: default result formats setting |