| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Invalid Assert while validating REPLICA IDENTITY? |
| Date: | 2024-09-10 08:46:27 |
| Message-ID: | CAA4eK1JM3WSn-Ta3-y4tQKW4-=Suj0MtcTHp2j20nbr1MBJfHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 10, 2024 at 11:36 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, 9 Sept 2024 at 13:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > The second part of the assertion is incomplete. The
> > IsIndexUsableForReplicaIdentityFull() should be used only when the
> > remote relation has REPLICA_IDENTITY_FULL set. I haven't tested all
> > possible cases yet but I think the attached should be a better way to
> > write this assertion.
>
> The changes look good to me.
>
Thanks, I'll push this tomorrow unless Dilip or anyone else has any
comments. BTW, as the current code doesn't lead to any bug or
assertion failure, I am planning to push this change to HEAD only, let
me know if you think otherwise.
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Motiani | 2024-09-10 08:50:50 | Re: long-standing data loss bug in initial sync of logical replication |
| Previous Message | Yugo NAGATA | 2024-09-10 08:45:57 | Re: Add has_large_object_privilege function |