| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dmitriy Sarafannikov <dsarafannikov(at)yandex(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Borodin Vladimir <root(at)simply(dot)name>, Хомик Кирилл <khomikki(at)yandex-team(dot)ru> |
| Subject: | Re: [PROPOSAL] Use SnapshotAny in get_actual_variable_range |
| Date: | 2017-05-06 12:02:10 |
| Message-ID: | CAA4eK1JF5NhptVmRtQ84B_M1VCrOhr3Guev_O5Vdt2BMqn9p-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 5, 2017 at 1:28 PM, Dmitriy Sarafannikov
<dsarafannikov(at)yandex(dot)ru> wrote:
> Amit, thanks for comments!
>
>> 1.
>> +#define InitNonVacuumableSnapshot(snapshotdata) \
>> + do { \
>> + (snapshotdata).satisfies = HeapTupleSatisfiesNonVacuumable; \
>> + (snapshotdata).xmin = RecentGlobalDataXmin; \
>> + } while(0)
>> +
>>
>> Can you explain and add comments why you think RecentGlobalDataXmin is
>> the right to use it here? As of now, it seems to be only used for
>> pruning non-catalog tables.
>
> Can you explain me, what value for xmin should be used there?
>
I think we can use RecentGlobalDataXmin for non-catalog relations and
RecentGlobalXmin for catalog relations (probably a check similar to
what we have in heap_page_prune_opt).
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-05-06 12:44:27 | Re: Not getting error if ALTER SUBSCRIPTION syntax is wrong. |
| Previous Message | Gavin Flower | 2017-05-06 10:56:06 | Re: password_encryption, default and 'plain' support |