Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
Date: 2024-11-08 10:56:05
Message-ID: CAA4eK1JEotM3K9JrDwhNJmfEuOW9bpV5Eh+TTneaOQiLJYfW6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 8, 2024 at 3:17 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> It appears that we are passing InvalidOid instead of InvalidRelFileNumber when calling index_create(). While this isn’t technically a bug, since InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the correct identifier for clarity and consistency.
>

Agreed. We already use InvalidRelFileNumber at one of the other
callers in index_concurrently_create_copy(). Your patch looks good to
me.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-11-08 11:00:40 Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
Previous Message David Rowley 2024-11-08 10:18:09 Re: define pg_structiszero(addr, s, r)