Re: pgsql: Make the order of the header file includes consistent in non-bac

On Fri, Oct 25, 2019 at 11:47 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> > One possible reason could be that pgtypeslib_extern.h has define like below:
> > #ifndef bool
> > #define bool char
> > #endif /* ndef bool */
>
> Possible. I have not looked closely.
>
> > It is possible that all the functions that have bool has a parameter
> > in dt_common.c treat it as 'char' where as the declaration of same
> > functions in dt.h doesn't consider bool as char because now
> > pgtypeslib_extern.h is included after dt.h. It seems that the
> > platforms where it failed doesn't have bool defined. What do you
> > think? I think we can revert the change in that file.
> >
> > BTW, prairiedog is also show similar failure and both seems to have
> > similar OS except for versions.
>
> Remembering the recent efforts that went behind stdbool.h (see
> 9a95a77), I think that we should be able to cleanup this header more.
> Reverting partially the change looks better for now to put that the
> buildfarm back to green.
>

Reverted and the buildfarm is green again. Thanks!

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com