Re: [HACKERS] logical decoding of two-phase transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2020-12-17 12:54:42
Message-ID: CAA4eK1JC_6u_Yo2+o814N2XYYvLHCF+=b9YTkt-tVbrCKm4p4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 17, 2020 at 9:30 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Thu, Dec 17, 2020 at 2:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > On again thinking about this, I think it is good to disable it during
> > slot initialization but will it create any problem because during slot
> > initialization we don't stream any xact and stop processing WAL as
> > soon as we reach CONSISTENT_STATE? Did you observe any problem with
> > this?
> >
> Yes, it did not stream any xact during initialization but I was
> surprised that the DecodePrepare code was invoked even though
> I hadn't created the subscription with twophase enabled. No problem
> was observed.
>

Fair enough, I have fixed this in the patch-series posted sometime back.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2020-12-17 13:03:56 Re: On login trigger: take three
Previous Message Amit Kapila 2020-12-17 12:53:29 Re: [HACKERS] logical decoding of two-phase transactions