Re: Inconsistency in determining the timestamp of the db statfile.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Inconsistency in determining the timestamp of the db statfile.
Date: 2020-09-10 07:05:01
Message-ID: CAA4eK1JCQW_ofzGDhcjOm9DYeEAQ8Hyrh2U0qpK-KTF3jcCkOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 10, 2020 at 11:52 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
>
> Regarding the v2 patch, I think we should return false in the
> following case too:
>
> default:
> ereport(pgStatRunningInCollector ? LOG : WARNING,
> (errmsg("corrupted statistics file \"%s\"",
> statfile)));
> goto done;
>

makes sense, attached find the updated patch.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v3-0001-Fix-inconsistency-in-determining-the-timestamp-of.patch application/octet-stream 2.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2020-09-10 07:25:48 Re: Inconsistent Japanese name order in v13 contributors list
Previous Message Michael Paquier 2020-09-10 06:58:31 Re: doc review for v13