From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Add contrib/pg_logicalsnapinspect |
Date: | 2024-08-26 13:35:27 |
Message-ID: | CAA4eK1JBd_nHxUSHv_4kECs-Yo7dvxRUBh+e-aFw2SzHUzdNsw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 22, 2024 at 5:56 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> Please find attached a patch to $SUBJECT.
>
> This module provides SQL functions to inspect the contents of serialized logical
> snapshots of a running database cluster, which I think could be useful for
> debugging or educational purposes.
>
+1. I see it could be a good debugging aid.
>
> 2. The SnapBuildOnDisk and SnapBuild structs are now exposed to public. Means
> we should now pay much more attention when changing their contents but I think
> it's worth it.
>
Is it possible to avoid exposing these structures? Can we expose some
function from snapbuild.c that provides the required information?
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2024-08-26 13:37:08 | Re: BitmapHeapScan streaming read user and prelim refactoring |
Previous Message | Joe Conway | 2024-08-26 13:25:04 | Re: how to log into commitfest.postgresql.org and begin review patch |