Re: pgsql: Extend pg_publication_tables to display column list and row filt

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Extend pg_publication_tables to display column list and row filt
Date: 2022-05-19 03:29:13
Message-ID: CAA4eK1JB_AqdQOaVGsV-RhFRCZo62m4mpn51aVNFH+suOitmrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, May 19, 2022 at 8:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <akapila(at)postgresql(dot)org> writes:
> > Extend pg_publication_tables to display column list and row filter.
>
> Is this really something to be doing post-beta1?
>

I am sorry if we don't allow to make catalog changes post-beta1. If we
can't do that then I can revert this and try to find a different
solution to the problem?

> > This information will be useful to users and we also need this for the
> > later commit that prohibits combining multiple publications with different
> > column lists for the same table.
>
> I'm very skeptical of any claim that system view contents should be
> involved in such a prohibition.
>

That is not the only way for such a prohibition but it appeared
simpler to do that way as we are already using that view and its
underlying function (pg_get_publication_tables) in the place where
prohibition has to be added.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-05-19 05:14:45 pgsql: Fix incorrect comments for Memoize struct
Previous Message Tom Lane 2022-05-19 03:10:52 Re: pgsql: Extend pg_publication_tables to display column list and row filt