From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Brad Nicholson <brad(dot)nicholson(at)instacart(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
Subject: | Re: No-op updates with partitioning and logical replication started failing in version 13 |
Date: | 2022-08-16 10:37:39 |
Message-ID: | CAA4eK1JAhysbquBgdassMj1dPPZ6r3J0Th+anPBtovW=TjVu5A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Tue, Aug 16, 2022 at 8:30 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> ii)
> Line:452(publication.sql)
> -- column list for partitioned tables has to cover replica identities for
> -- all child relations
>
> OK - That does seem to have leaf partitions with PK and a partitioned
> table without PK, but OTOH this is in the scope of column list testing
>
> So, I agree with you - it does seem all the cases are covered. But,
> IMO this is quite a large file which is too hard to digest all at
> once, and because of that I still felt that keeping all related test
> cases grouped together (even if that causes some doubling-up of a few
> scenarios) would be better for future readability/maintenance than
> relying on some distantly scattered tests to cover everything. Anyway,
> I leave it for you to decide whether to add more tests or not.
>
I am not sure if repeating tests is a good idea. However, if you find
a better way to group the tests, feel free to propose them separately.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-08-16 10:38:21 | Re: No-op updates with partitioning and logical replication started failing in version 13 |
Previous Message | Devrim Gündüz | 2022-08-16 10:04:29 | Re: BUG #17588: RHEL 8 nothing provides libarmadillo.so.10 (64bit) needed by gdal-libs3x* |