Re: [HACKERS] PATCH: Batch/pipelining support for libpq

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vaishnaviprabakaran(at)gmail(dot)com, Craig Ringer <craig(at)2ndquadrant(dot)com>, daniel(at)manitou-mail(dot)org, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, "Prabakaran, Vaishnavi" <VaishnaviP(at)fast(dot)au(dot)fujitsu(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, dmitigr(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, m(dot)kniep(at)web(dot)de, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, iwata(dot)aya(at)jp(dot)fujitsu(dot)com, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [HACKERS] PATCH: Batch/pipelining support for libpq
Date: 2019-09-09 07:20:26
Message-ID: CAA4eK1J8QqgyysqoFn6=q8zButwtJPbLGWMYC-48NO6ANj0P=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 30, 2019 at 7:06 PM Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> wrote:
>
> Hi,
>
> > > This patch has been around for some time now, the last version fails to
> > > apply cleanly and in-depth reviews have happened. I am moving that to
> > > the next CF, waiting on its author.
> >
> > Unfortunately, nothing was changed since then, so there is already some amount
> > of unaddressed review feedback. I'll move this patch to "Returned with
> > feedback".
> >
>
> Craig Ringer mentioned about this thread to me recently.
>
> This effort has seen decent reviews from Craig, Andres and Michael
> already. So, I thought of refreshing it to work against latest master
> HEAD.
>

Thanks for picking up this. However, I noticed that previously
Horiguchi-San has given some comments on this patch [1] which doesn't
seem to be addressed or at least not all of them are addressed. It is
possible that you would have already addressed those, but in that
case, it would be good if you respond to his email as well. If those
are not addressed, then it will be good to address those.

[1] - https://www.postgresql.org/message-id/20180322.211148.187821341.horiguchi.kyotaro%40lab.ntt.co.jp

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-09-09 07:31:59 Re: [HACKERS] CLUSTER command progress monitor
Previous Message Jamison, Kirk 2019-09-09 06:52:03 RE: [PATCH] Speedup truncates of relation forks