Re: [HACKERS] logical decoding of two-phase transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2020-12-31 05:18:52
Message-ID: CAA4eK1J7TiOQSiDq9MS_4k7zr4Jca7SnO8Vy3L4wtc7t1X9zsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 30, 2020 at 6:49 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Dec 29, 2020 at 3:15 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > Hi Sawada-san,
> >
> > I think Amit has a plan to commit this patch-set in phases.
> >
>
> I have pushed the first patch and I would like to make a few changes
> in the second patch after which I will post the new version. I'll try
> to do that tomorrow if possible and register the patch.
>

Please find attached a rebased version of this patch-set. I have made
a number of changes in the
v35-0001-Allow-decoding-at-prepare-time-in-ReorderBuffer.

1. Centralize the logic to decide whether to perform decoding at
prepare time in FilterPrepare function.
2. Changed comments atop DecodePrepare. I didn't like much the
comments changed by Ajin in the last patch.
3. Merged the doc changes patch after some changes mostly cosmetic.

I am planning to commit the first patch in this series early next week
after reading it once more.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v35-0001-Allow-decoding-at-prepare-time-in-ReorderBuffer.patch application/octet-stream 74.8 KB
v35-0002-Refactor-spool-file-logic-in-worker.c.patch application/octet-stream 3.6 KB
v35-0003-Track-replication-origin-progress-for-rollbacks.patch application/octet-stream 3.9 KB
v35-0004-Add-support-for-apply-at-prepare-time-to-built-i.patch application/octet-stream 38.9 KB
v35-0005-Support-2PC-txn-subscriber-tests.patch application/octet-stream 60.4 KB
v35-0006-Support-2PC-txn-Subscription-option.patch application/octet-stream 34.9 KB
v35-0007-Support-2PC-consistent-snapshot-isolation-tests.patch application/octet-stream 5.1 KB
v35-0008-Support-2PC-txn-tests-for-concurrent-aborts.patch application/octet-stream 16.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-12-31 05:23:12 Re: Parallel Inserts in CREATE TABLE AS
Previous Message David Fetter 2020-12-31 03:28:14 WIP: document the hook system