Re: Fix inconsistencies for v12

On Tue, May 28, 2019 at 10:30 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> 28.05.2019 2:05, Amit Kapila wrote:
> > On Mon, May 27, 2019 at 3:59 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> >>> On Sun, May 26, 2019 at 2:20 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> >>>> 5. ExecContextForcesOids - not changed, but may be should be removed
> >>>> (orphaned after 578b2297)
> >>> Yes, we should remove the use of ExecContextForcesOids.
> >> Unless grep is failing me, ExecContextForcesOids is in fact gone.
> >> All that's left is one obsolete mention in a comment, which should
> >> certainly be cleaned up.
> >>
..
> > */
> I got a coredump with `make installcheck-world` (on postgres_fdw test):
>

Thanks for noticing this. I have run the tests in parallel mode with
something like make -s check-world -j4 PROVE_FLAGS='-j4'. It didn't
stop at failure, so I missed to notice it. However, now looking
carefully (by redirecting the output to a log file), I could see this.

>
> (On a side note, I agree with your remarks regarding 2 and 3; please
> look at a better patch for 3 attached.)
>

The new patch looks good to me. However, instead of committing just
this one alone, I will review others as well and see which all can be
combined and pushed together.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com