From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: INSERT INTO SELECT, Why Parallelism is not selected? |
Date: | 2020-07-27 03:27:34 |
Message-ID: | CAA4eK1J4Q37h7qKrLPGfMReZ7nnXU=C5+VwyZ2Eci_ypbqg+Ew@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jul 26, 2020 at 4:54 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Jul 25, 2020 at 8:42 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
>
> No, "git diff --check" doesn't help. I have tried pgindent but that
> also doesn't help neither was I expecting it to help. I am still not
> able to figure out how I goofed up this but will spend some more time
> on this.
>
I think I have figured out how the patch ended up having  . Some
editors add it when we use two spaces after a period (.) and I could
see that my Gmail client does that for such a pattern. Normally, I
use one of MSVC, vi, or NetBeans IDE to develop code/patch but
sometimes I check the comments by pasting in Gmail client to find
typos or such and then fix them manually. I guess in this case I have
used Gmail client to write this comment and then copy/pasted it for
the patch. I will be careful not to do this in the future.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2020-07-27 03:52:42 | Allows Extend Protocol support CURSOR_OPT_HOLD with prepared stmt. |
Previous Message | Justin Pryzby | 2020-07-27 02:54:02 | Re: HashAgg's batching counter starts at 0, but Hash's starts at 1. |