From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, YUriy Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Move PinBuffer and UnpinBuffer to atomics |
Date: | 2016-03-31 13:59:13 |
Message-ID: | CAA4eK1J44ucJjDR7MM=s=zvAWMcU4AUh7__sSAmtd638CKr=ZA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 29, 2016 at 10:52 PM, Alexander Korotkov <
a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> Hi, Andres!
>
> Please, find next revision of patch in attachment.
>
>
Couple of minor comments:
+ * The following two macroses
is macroses right word to be used here?
+ * of this loop. It should be used as fullowing:
/fullowing/following
+ * For local buffers usage of these macros shouldn't be used.
isn't it better to write it as
For local buffers, these macros shouldn't be used.
static int ts_ckpt_progress_comparator(Datum a, Datum b, void *arg);
-
Spurious line deletion.
+ * Since buffers are pinned/unpinned very frequently, this functions tries
+ * to pin buffer as cheap as possible.
/this functions tries
which functions are you referring here? Comment seems to be slightly
unclear.
! if (XLogHintBitIsNeeded() && (pg_atomic_read_u32(&bufHdr->state) &
BM_PERMANENT))
Is there a reason that you have kept macro's to read refcount and
usagecount, but not for flags?
Apart from this, I have verified that patch compiles on Windows and passed
regressions (make check)!
Nice work!
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-03-31 14:13:44 | Re: Performance degradation in commit 6150a1b0 |
Previous Message | Andrew Dunstan | 2016-03-31 13:53:19 | Re: So, can we stop supporting Windows native now? |