| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Mahendra Singh <mahi6run(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Block level parallel vacuum |
| Date: | 2019-12-24 03:36:35 |
| Message-ID: | CAA4eK1J3_wBtC=9swQYmyKhRJf_j-1pu2et565QpVa89yjQR3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 23, 2019 at 11:02 PM Mahendra Singh <mahi6run(at)gmail(dot)com> wrote:
>
> 5. I am not sure that I am right but I can see that we are not consistent while ending the single line comments.
>
> I think, if single line comment is started with "upper case letter", then we should not put period(dot) at the end of comment, but if comment started with "lower case letter", then we should put period(dot) at the end of comment.
>
> a)
> + /* parallel vacuum must be active */
> I think. we should end above comment with dot or we should make "p" of parallel as upper case letter.
>
> b)
> + /* At least count itself */
> I think, above is correct.
>
I have checked a few files in this context and I don't see any
consistency, so I would suggest keeping the things matching with the
nearby code. Do you have any reason for the above conclusion?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-24 04:19:09 | Re: error context for vacuum to include block number |
| Previous Message | Masahiko Sawada | 2019-12-24 03:22:36 | Re: Online checksums verification in the backend |