From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: freeze map open item |
Date: | 2016-07-22 08:27:15 |
Message-ID: | CAA4eK1J3FdsdAFBPqizcxt5W4uDuKrf=1kYPmk4+mXmUsnD=mw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 21, 2016 at 9:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> The open items list says this:
>
> heap_update sets xmax and infomask without logging the changes or
> clearing PD_ALL_VISIBLE or visibility map bits
> * volunteer owner wanted
> * This has been buggy essentially forever but the freeze map changes
> give it new urgency.
> * Andres working on committing patches
>
> I believe this issue was fully resolved by
> bfa2ab56bb8c512dc8613ee3ff0936568a1c8418. Is that correct?
> Regardless, I'd like to extend sincere and heartfelt thanks to Andres
> for handling this issue, because I was sure running out of steam (and
> time).
>
> Two other issues were discussed on that thread for which no open
> issues were created. First, heap_lock_tuple failed to clear the
> all-frozen status. I believe that
> eca0f1db14ac92d91d54eca8eeff2d15ccd797fa substantially addressed that
> issue and therefore it should be added to the list as a resolved
> issue. But, second, as noted in further discussion on that thread and
> in the commit message, there is an outstanding theoretical problem
> which is non-critical but worthy of being fixed. I recommend we open
> a new open issue for that, or at least fix it.
>
+1. I think, sometime needs to be spend to confirm if that
theoretical risk can practically cause any problem. I am planning to
spend some time on it in next week or so and will report my
observations on that thread.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2016-07-22 08:35:48 | Re: Constraint merge and not valid status |
Previous Message | Kyotaro HORIGUCHI | 2016-07-22 08:15:14 | Re: asynchronous and vectorized execution |