Re: pg_background (and more parallelism infrastructure patches)

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_background (and more parallelism infrastructure patches)
Date: 2014-11-20 12:30:40
Message-ID: CAA4eK1J2kw2Pb4uK=iwPVVVAF_cquDMoN-gLkVGnMqcoYwKv-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 12, 2014 at 11:09 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Wed, Nov 12, 2014 at 11:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com>
wrote:
> > On Wed, Nov 12, 2014 at 11:19 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> >> The question is whether the library is actually loaded in that case?
> >> Because that normally only happens early during startup - which is why
> >> it's a PGC_BACKEND guc.
> >
> > It looks like that does not work.
> >
> > [rhaas pgsql]$ PGOPTIONS='-c local_preload_libraries=auto_explain' psql
> > psql (9.5devel)
> > Type "help" for help.
> >
> > rhaas=# select * from pg_background_result(pg_background_launch('show
> > auto_explain.log_min_duration')) as (x text);
> > ERROR: unrecognized configuration parameter
"auto_explain.log_min_duration"
> > CONTEXT: background worker, pid 31316
> >
> > So, there's more to be done here. Rats.
>
> It turned out to be quite simple to fix both problems.
>
> Updated patches attached.
>

Few compilation errors in the patch:
1>contrib\postgres_fdw\postgres_fdw.c(2107): error C2198:
'set_config_option' : too few arguments for call
1>contrib\postgres_fdw\postgres_fdw.c(2111): error C2198:
'set_config_option' : too few arguments for call
1>contrib\postgres_fdw\postgres_fdw.c(2115): error C2198:
'set_config_option' : too few arguments for call
2>contrib\dblink\dblink.c(2983): error C2198: 'set_config_option' : too few
arguments for call

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2014-11-20 13:37:43 Re: New Event Trigger: table_rewrite
Previous Message Simon Riggs 2014-11-20 11:58:29 Re: proposal: plpgsql - Assert statement