Re: logical decoding : exceeded maxAllocatedDescs for .spill files

On Tue, Nov 26, 2019 at 11:19 AM Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>
> On Tue, 26 Nov 2019 at 10:49, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > So, what is the next step here? How about if we somehow check whether
> > the file exists before doing unlink, say by using stat?
> But the thing is, the behaviour is so much in a grey area, that we
> cannot reliably say for instance that when stat() says there is no
> such file, there is indeed no such file,
>

Why so?

> and if we re-create the same
> file when it is still open, it is always going to open a new file,
> etc.
>

Yeah, or maybe even if we don't create with the same name, there is
always be some dangling file which again doesn't sound like a good
thing.

> > If that doesn't work, I think we might need to go in the direction of tracking
> > file handles in some way, so that they can be closed during an abort.
> Yeah, that is one way. I am still working on different approaches.
> WIll get back with proposals.
>

Fair enough. See, if you can also consider an approach that is local
to ReorderBuffer module wherein we can track those handles in
ReorderBufferTxn or some other place local to that module.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com