Re: Patch: show relation and tuple infos of a lock to acquire

On Thu, Mar 13, 2014 at 8:06 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Mar 13, 2014 at 7:10 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Thu, Mar 13, 2014 at 12:45 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> _bt_doinsert - "insert index tuple (X,Y)" (here it will refer to index tuple
>>> location)
>>
>> I don't think that giving the index tuple location is going to be very
>> helpful; can we get the TID for conflicting heap tuple?
>
> Yes, each index tuple contains reference to TID of heap tuple.

I have updated the patch to pass TID and operation information in
error context and changed some of the comments in code.
Let me know if the added operation information is useful, else
we can use better generic message in context.

Christian, can you please once confirm if the attached patch looks
okay to you?
According to me all the comments raised till now for this patch are
addressed, so I will mark it as Ready For Committer unless some
one feels we should do something else for this patch.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com