Re: [bug fix] pg_ctl always uses the same event source

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2014-01-23 14:23:04
Message-ID: CAA4eK1J16013jT2Vb91ADOWe-dWrP1VkHt3hj0g7Ng4p5eOEOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 23, 2014 at 10:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>> On Wed, Jan 22, 2014 at 9:03 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> So? Anything which can know the value of a GUC parameter can certainly
>>> know the selected port number.
>
>> 1. In case of registration of event source, either user has to pass the name
>> or it uses hard coded default value, so if we use version number along with
>> 'PostgreSQL', it can be consistent.
>> I don't see any way pgevent.c can know port number to append it to default
>> value, am I missing something here?
>
>
> I think what we might want to do is redefine the server's behavior
> as creating an event named after the concatenation of event_source
> and port number, or maybe even get rid of event_source entirely and
> just say it's "PostgreSQL" followed by the port number.

To accomplish this behaviour, each time server starts and stops,
we need to register and unregister event log using mechanism
described at below link to ensure that there is no mismatch between
what server uses and what OS knows.
http://www.postgresql.org/docs/devel/static/event-log-registration.html

IIUC, this will be a much larger behaviour change.
What is the problem you are envisioning if we use version number,
yesterday I have given some examples about other softwares which
are registered in event log and uses version number, so I don't
understand why it is big deal if we also use version number along with
PostgreSQL as a default value and if user specifies any particular name
then use the same.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-01-23 14:43:04 Re: commit fest 2014-01 week 1 report
Previous Message Andrew Dunstan 2014-01-23 14:18:26 Re: Add min and max execute statement time in pg_stat_statement