From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: option -T in pg_basebackup doesn't work on windows |
Date: | 2014-08-22 04:08:11 |
Message-ID: | CAA4eK1J=NZYFYiXzeSFWFNjunZaXX-S279+xq-mYiAjg_b3YxQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 21, 2014 at 3:44 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
>
> On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> > On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas <
hlinnakangas(at)vmware(dot)com> wrote:
> > >Wouldn't it make a lot more sense to create it correctly in the first
place?
> >
> > Looking at the code, I think it is very well possible to create
> > it correctly in the first place without much extra work. I will
> > send a patch if nobody sees any problem with this change.
>
> Attached patch implements the above suggested fix.
> I have removed the earlier code which was used to update the
> symlink path.
Today morning, I realised that there is one problem with the
patch I sent yesterday and the problem is that incase user
has not given -T option, it will not be able to create the symlink
for appropriate path. Attached patch fix this issue.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
pg_basebackup_relocate_tablespace_v4.patch | application/octet-stream | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | furuyao | 2014-08-22 04:35:48 | Re: pg_receivexlog --status-interval add fsync feedback |
Previous Message | Alvaro Herrera | 2014-08-22 03:58:58 | Re: inherit support for foreign tables |