| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Regardign RecentFlushPtr in WalSndWaitForWal() |
| Date: | 2024-03-11 11:06:18 |
| Message-ID: | CAA4eK1J+k_7Z1+D108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 11, 2024 at 4:17 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > Right, I think the quoted code has check "if (!RecoveryInProgress())".
> >
> > >
> > But apart from that, your
> > > observation seems accurate, yes.
> > >
> >
> > I also find the observation correct and the code has been like that
> > since commit 5a991ef8 [1]. So, let's wait to see if Robert or Andres
> > remembers the reason, otherwise, we should probably nuke this code.
>
> Please find the patch attached for the same.
>
LGTM. I'll push this tomorrow unless I see any comments/objections to
this change.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-03-11 11:18:01 | Re: Transaction timeout |
| Previous Message | Andrey M. Borodin | 2024-03-11 10:52:57 | Re: Transaction timeout |