From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: PHJ file leak. |
Date: | 2019-11-13 08:52:45 |
Message-ID: | CAA4eK1J+e4OfBYVUTF-DdbsWUjYWMbn1yy_mtgihXoTaWPN_Hw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 13, 2019 at 6:13 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Wed, 13 Nov 2019 09:48:19 +1300, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote in
> >
> > Here's the version I'd like to commit in a day or two, once the dust
> > has settled on the minor release. Instead of adding yet another copy
> > of that code, I just moved it out of the loop; this way there is no
> > way to miss it. I think the comment could also be better, but I'll
> > wait for the concurrent discussions about the meaning of
> > ExecShutdownNode() to fix that in master.
>
> The phatch's shape looks better. Thanks.
>
+1. LGTM as well.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2019-11-13 08:57:13 | Re: [HACKERS] Block level parallel vacuum |
Previous Message | Amit Kapila | 2019-11-13 08:51:13 | Re: Coding in WalSndWaitForWal |