Re: pgsql: Extend pg_publication_tables to display column list and row filt

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Extend pg_publication_tables to display column list and row filt
Date: 2022-05-30 03:06:12
Message-ID: CAA4eK1J+DDcYgHo47EjwjkAauax4wxCQN4i+CMehM83Wt9bP5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, May 29, 2022 at 2:00 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2022-05-19 08:59:13 +0530, Amit Kapila wrote:
> > On Thu, May 19, 2022 at 8:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >
> > > Amit Kapila <akapila(at)postgresql(dot)org> writes:
> > > > Extend pg_publication_tables to display column list and row filter.
> > >
> > > Is this really something to be doing post-beta1?
> > >
> >
> > I am sorry if we don't allow to make catalog changes post-beta1.
>
> I don't think there's a hard prohibition of catalog changes. But we should be
> careful doing them because it makes testing more painful etc.
>

I agree. In this case, it seemed like a better way to solve the
problem at hand. I have tried to explain the problem in -hackers
thread at [1] and the latest patch (which required the change in this
commit) for it is posted in email [2]. Can you please once check that?

[1] - https://www.postgresql.org/message-id/CAA4eK1KrXS0js9S0YFQRh9Vf5kaVOyz%3DNqA%3D0vMHvF1kxUJVkA%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/OS0PR01MB5716FFBE5AACA8707C3420E994D89%40OS0PR01MB5716.jpnprd01.prod.outlook.com

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-05-30 05:30:01 pgsql: logging: Also add the command prefix to detail and hint messages
Previous Message Michael Paquier 2022-05-30 01:57:50 pgsql: doc: Reword description of roles able to view track_activities's