Re: automatically generating node support functions

On Wed, Aug 3, 2022 at 7:16 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > I have a question related to commit 964d01ae90. Today, after getting
> > the latest code, when I compiled it on my windows machine, it lead to
> > a compilation error because the outfuncs.funcs.c was not regenerated.
> > I did the usual steps which I normally perform after getting the
> > latest code (a) run "perl mkvcbuild.pl" and (b) then build the code
> > using MSVC. Now, after that, I manually removed "node-support-stamp"
> > from folder src/backend/nodes/ and re-did the steps and I see that the
> > outfuncs.funcs.c got regenerated, and the build is also successful. I
> > see that there is handling to clean the file "node-support-stamp" in
> > nodes/Makefile but not sure how it works for windows. I think I am
> > missing something here. Can you please guide me?
>
> More likely, we need to add something explicit to Mkvcbuild.pm
> for this. I recall that it has stanzas to deal with updating
> other autogenerated files; I bet we either missed that or
> fat-fingered it for node-support-stamp.
>

I see below logic added by commit which seems to help regenerate the
required files.

+++ b/src/tools/msvc/Solution.pm
@@ -839,6 +839,54 @@ EOF
close($chs);
}

+ if (IsNewer(
+ 'src/backend/nodes/node-support-stamp',
+ 'src/backend/nodes/gen_node_support.pl'))
...
...

Now, in commit 1349d2790b, we didn't change anything in
gen_node_support.pl but changed "typedef struct AggInfo" due to which
we expect the files like outfuncs.funcs.c gets regenerated. However,
as there is no change in gen_node_support.pl, the files didn't get
regenerated.

--
With Regards,
Amit Kapila.