Re: [PATCH] Simple progress reporting for COPY command

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Simple progress reporting for COPY command
Date: 2021-01-08 04:05:46
Message-ID: CAA4eK1+wYBP0kE60jX5knn0bXyuZjp7kcNRSBCSK7gkLbikdAg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 8, 2021 at 8:42 AM Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> wrote:
>
> pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> napsal:
> >
> >
> > Can't we display the entire COPY command? I checked that
> > pg_stat_statements display the query so there shouldn't be a problem
> > to display the entire command.
>
> In previous discussions there was mentioned it doesn't make sense
> since you can join with pg_stat_statements on the pid column if
> needed. What would be the reason to duplicate that info?
>

But pg_stat_staments won't be present by default. Also, the same
argument could be applied for the command to be present in
stat_progress views. It occurred to me only when I was trying to
compare what we display in all the progress views. I think there is
some merit in being consistent.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josef Šimánek 2021-01-08 04:15:16 Re: [PATCH] Simple progress reporting for COPY command
Previous Message Keisuke Kuroda 2021-01-08 04:02:38 Re: Huge memory consumption on partitioned table with FKs