| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Fix cardinality estimates for parallel joins. |
| Date: | 2017-03-15 07:00:25 |
| Message-ID: | CAA4eK1+uWz-NUs9JDMUjFR0_ONiuAqmEkM_5NPqFOaRFPtNC-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Mar 14, 2017 at 9:59 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Jan 17, 2017 at 11:49 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Jan 16, 2017 at 7:23 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>>
>>>
>>> Isn't it better to call clamp_row_est in join costing functions as we
>>> are doing in cost_seqscan()? Is there a reason to keep those
>>> different?
>>
>> No, those should probably be changed to match.
>
> So I guess that'd look something like this?
>
Yes, the patch looks good to me.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-15 11:25:12 | pgsql: Cosmetic fixes for hash index write-ahead logging. |
| Previous Message | Amit Kapila | 2017-03-15 05:49:42 | Re: pgsql: hash: Add write-ahead logging support. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2017-03-15 07:00:37 | Re: PATCH: Configurable file mode mask |
| Previous Message | Amit Langote | 2017-03-15 06:32:10 | Re: Partitioned tables and relfilenode |