| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Track in pg_replication_slots the reason why slots conflict? |
| Date: | 2024-01-01 11:00:41 |
| Message-ID: | CAA4eK1+sC1t-GSLQqZYT9tbyjW1kg2V5Rgn=POuDPFywrapoTQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 1, 2024 at 12:32 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> PFA v3 after changing column name to 'conflict_reason'
>
Few minor comments:
===================
1.
+ <para>
+ <literal>wal_removed</literal> = required WAL has been removed.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>rows_removed</literal> = required rows have been removed.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>wal_level_insufficient</literal> = wal_level
insufficient on the primary server.
+ </para>
Should we use the same style to write the description as we are using
for the wal_status column? For example, <literal>wal_removed</literal>
means that the required WAL has been removed.
2.
+ <para>
+ The reason of logical slot's conflict with recovery.
My grammar tool says it should be: "The reason for the logical slot's
conflict with recovery."
Other than these minor comments, the patch looks good to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ivan Kush | 2024-01-01 11:15:27 | Re: Autonomous transactions 2023, WIP |
| Previous Message | Michael Paquier | 2024-01-01 10:25:16 | Update for copyright messages to 2024 (Happy New Year!) |