Re: PostgreSQL 15 minor fixes in protocol.sgml

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Ekaterina Kiryanova <e(dot)kiryanova(at)postgrespro(dot)ru>, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: PostgreSQL 15 minor fixes in protocol.sgml
Date: 2022-08-03 03:57:58
Message-ID: CAA4eK1+p0Z41Ckqp_RBOCKtDpxRj6RYK1N9=-gxao7Kknre0Hw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Tue, Aug 2, 2022 at 4:28 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote:
>
> > Another point worth mentioning is that only this file contains the phrase
> > "two-phase transaction". I believe that "two-phase commit transaction" or
> > "transaction prepared for two-phase commit" depending on the situation would
> > be better wording.
>
> "Prepare for two-phase commit" may be clearer?
>

I think we can use just "Prepared transaction" instead. So, the
message "The user defined GID of the two-phase transaction." can be
changed to "The user defined GID of the prepared transaction.".
Similarly, the message "Identifies the message as a two-phase prepared
transaction message." could be changed to: "Identifies the message as
a prepared transaction message."

> > And finally, could you please clarify this part?
> > -- The end LSN of the prepare transaction.
> > Is it a typo of "prepared transaction"?

I think in this case it should be a "prepared transaction".

Thanks for the report and Thanks Michael for including me. I am just
redirecting it to -hackers so that others involved in this feature
also can share their views.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Peter Smith 2022-08-03 05:26:25 Re: PostgreSQL 15 minor fixes in protocol.sgml
Previous Message PG Doc comments form 2022-08-02 20:08:07 Usage instructions for pg_hba.conf file

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-08-03 04:05:30 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Previous Message David Rowley 2022-08-03 03:33:57 Re: Speed up transaction completion faster after many relations are accessed in a transaction