From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Explain [Analyze] produces parallel scan for select Into table statements. |
Date: | 2016-03-12 06:58:56 |
Message-ID: | CAA4eK1+n03Gg_c5wnY_BJ=U+uiNJvbaZqf2dyDE8tWzg+uirJw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 11, 2016 at 3:34 PM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
wrote:
>
> On Thu, Mar 10, 2016 at 9:39 PM, Robert Haas <robertmhaas(at)gmail(dot)com>
wrote:
> >I guess there must not be an occurrence of this pattern in the
> >regression tests, or previous force_parallel_mode testing would have
> >found this problem. Perhaps this patch should add one?
>
> I have added the test to select_into.sql. Added Explain select into
statement.
>
I don't see how this test will fail with force_parallel_mode=regress and
max_parallel_degree > 0 even without the patch proposed to fix the issue in
hand. In short, I don't think this test would have caught the issue, so I
don't see much advantage in adding such a test. Even if we want to add
such a test case, I think as proposed this will substantially increase the
timing for "Select Into" test which might not be an acceptable test case
addition especially for testing one corner case.
>
> Explain Analyze produces planning time and execution time even with
TIMING OFF
> so not adding the same to regress tests.
>
Yeah, that makes the addition of test for this functionality difficult.
Robert, do you have any idea what kind of test would have caught this issue?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Kuleshov | 2016-03-12 07:09:54 | [PATCH] Use MemoryContextAlloc() in the MemoryContextAllocZero() and MemoryContextAllocZeroAligned() |
Previous Message | Pavel Stehule | 2016-03-12 06:24:49 | Re: raw output from copy |