From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Vasilyev <d(dot)vasilyev(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |
Date: | 2016-05-26 10:01:36 |
Message-ID: | CAA4eK1+kN711q6nfoNKnuOOeM8zR=9Kv8+hW-Z=SUcnf=FQnZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, May 25, 2016 at 9:44 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> On Wed, May 25, 2016 at 12:11 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> >
> > Okay, attached patch just does that and I have verified that it allows
to
> > start multiple services in windows. In off list discussion with
Robert, he
> > suggested not to complicate the patch by retrying for fixed number of
times
> > as there is no proof that ERROR_ACCESS_DENIED can occur due to any other
> > reason in this code path. This patch is based on Kyotaro san's patch
posted
> > upthread with just minor changes in comments and indentation.
>
> Thanks for catching Robert and getting confirmation on the matter. In
> the same line of thoughts, I think as well that it is definitely not
> worth complicating the retry logic in dsm.c, but you knew that already
> per last week's discussion.
>
> Regarding the patch, this looks good to me.
>
Thanks for reviewing the patch. I have added the entry for this patch in
next CF (https://commitfest.postgresql.org/10/636/) feel free to mark it
as Ready for committer if you think patch is good.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2016-05-26 11:25:56 | Re: foreign table batch inserts |
Previous Message | Amit Kapila | 2016-05-26 09:57:40 | Re: [sqlsmith] Failed assertions on parallel worker shutdown |