Re: run pgindent on a regular basis / scripted manner

On Thu, Feb 2, 2023 at 5:05 PM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> On Thu, 2 Feb 2023 at 06:40, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Noah Misch <noah(at)leadboat(dot)com> writes:
> > > Regarding the concern about a pre-receive hook blocking an emergency push, the
> > > hook could approve every push where a string like "pgindent: no" appears in a
> > > commit message within the push. You'd still want to make the tree clean
> > > sometime the same week or so. It's cheap to provide a break-glass like that.
> >
> > I think the real question here is whether we can get all (or at least
> > a solid majority of) committers to accept such draconian constraints.
> > I'd buy into it, and evidently so would you, but I can't help noting
> > that less than a quarter of active committers have bothered to
> > comment on this thread. I suspect the other three-quarters would
> > be quite annoyed if we tried to institute such requirements.
> >
>
> I didn't reply until now, but I'm solidly in the camp of committers
> who care about keeping the tree properly indented, and I wouldn't have
> any problem with such a check being imposed.
>
> I regularly run pgindent locally, and if I ever commit without
> indenting, it's either intentional, or because I forgot, so the
> reminder would be useful.
>
> And as someone who runs pgindent regularly, I think this will be a net
> time saver, since I won't have to skip over other unrelated indent
> changes all the time.
>

+1.

--
With Regards,
Amit Kapila.