| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size |
| Date: | 2025-02-17 10:36:34 |
| Message-ID: | CAA4eK1+h4WumWRrKNBk+vbEsLpPJXvGzkJXwdDeym4TC87OZjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 23, 2025 at 6:42 PM Shubham Khanna
<khannashubham1197(at)gmail(dot)com> wrote:
>
> Fixed the given comments. The attached patch contains the suggested changes.
>
I am fine with giving a WARNING for max_slot_wal_keep_size but I don't
think we need a test for each and every setting required for
pg_createsubscriber. This will add time to the tests without adding
much value. So, I don't think this patch deserves an additional test.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-02-17 10:50:11 | Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |
| Previous Message | Álvaro Herrera | 2025-02-17 10:36:29 | Re: New buildfarm animals with FIPS mode enabled |