Re: pgsql: Allow pgoutput to send logical decoding messages.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Amit Kapila <akapila(at)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Allow pgoutput to send logical decoding messages.
Date: 2021-04-06 09:34:55
Message-ID: CAA4eK1+faTVhxSrVthLxP6N1Smo5cdAarLtOjQwKND+meyMpJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 6, 2021 at 2:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Apr 6, 2021 at 8:55 AM Amit Kapila <akapila(at)postgresql(dot)org> wrote:
> >
> > Allow pgoutput to send logical decoding messages.
> >
>
> One of the tests added by this commit is failing:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2021-04-06%2005%3A45%3A20
>
> I think there is a race condition in one of the tests. I'll analyze
> this further.
>

As this is a timing issue so not easy to reproduce but as per my
analysis in the tests, after disabling the subscription, we were not
waiting for the replication connection to drop from the publisher. So
later when the test was trying to use the same slot to fetch the
messages via SQL API, it sometimes gives an error that the replication
slot is active for other PID. I have pushed a fix for this.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-04-06 09:56:22 pgsql: ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION
Previous Message Amit Kapila 2021-04-06 09:31:13 pgsql: Fix the tests added by commit ac4645c015.