| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: repeated decoding of prepared transactions |
| Date: | 2021-02-27 06:08:37 |
| Message-ID: | CAA4eK1+egwKKXY3b25+pGJGBBjvnjitro_29i7bwGCzayQ_OxA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 26, 2021 at 4:13 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Fri, Feb 26, 2021 at 7:47 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> > I've updated snapshot_was_exported_at_ member to pg_replication_slots as well.
> > Do have a look and let me know if there are any comments.
>
> Update with both patches.
>
Thanks, I have made some minor changes to the first patch and now it
looks good to me. The changes are as below:
1. Removed the changes related to exposing this new parameter via view
as mentioned in my previous email.
2. Changed the variable name initial_consistent_point.
3. Ran pgindent, minor changes in comments, and modified the commit message.
Let me know what you think about these changes.
Next, I'll review your second patch which allows the 2PC option to be
enabled only at slot creation time.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Avoid-repeated-decoding-of-prepared-transactions-.patch | application/x-patch | 16.0 KB |
| v5-0002-Add-option-to-enable-two-phase-commits-in-pg_crea.patch | application/x-patch | 40.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-02-27 07:16:13 | Re: SEARCH and CYCLE clauses |
| Previous Message | Ajin Cherian | 2021-02-27 06:02:17 | Re: repeated decoding of prepared transactions |