Re: Fix slot synchronization with two_phase decoding enabled

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix slot synchronization with two_phase decoding enabled
Date: 2025-04-29 03:46:18
Message-ID: CAA4eK1+aq7PavZ9RUUhHi6Y4QmHwRS7qjqRBX6hyN+8xM7B-vw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 28, 2025 at 11:54 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Sat, Apr 26, 2025 at 5:07 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Fri, Apr 25, 2025 at 9:57 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > On Fri, Apr 25, 2025 at 3:43 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > > The second can mislead the user
> > > > for a long period in cases where prepare and commit have a large time
> > > > gap. I feel this will introduce complexity either in the form of code
> > > > or in giving the information to the user.
> > >
> > > Agreed. Both ways introduce complexity so we need to consider the
> > > user-unfriendliness (by not having a proper way to enable failover for
> > > the two_phase-enabled-slot using SQL API) vs. risk (of introducing
> > > complexity).
> > >
> >
> > Right, to me it sounds risky to provide such functionality for SQL API
> > in the back branch.
>
> So do you think it's okay to leave it as a restriction (i.e. there is
> no easy way to enable failover for a two_phase-enabled logical slot
> created by SQL API)? or do you have any better idea for that?
>

I don't have any better ideas. I think it is better to leave it as a
restriction.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-04-29 05:45:24 Re: DOCS - create publication (tweak for generated columns)
Previous Message Noah Misch 2025-04-29 01:49:13 Re: dispchar for oauth_client_secret