| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add wait_for_subscription_sync for TAP tests. |
| Date: | 2022-08-03 11:25:37 |
| Message-ID: | CAA4eK1+ZE8QTkwZyqRf1muMrQeHSa3O3VPbcJTdQcTnUoPbFQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Aug 3, 2022 at 4:15 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-Aug-03, Amit Kapila wrote:
>
> > The new function wait_for_subscription_sync() can be used to replace the
> > above code. This eliminates duplicated code and makes it easier to write
> > future tests.
>
> Hmm, if you don't backpatch this, it might become a hurdle if we later
> backpatch tests that use it.
>
Yeah, that can happen for bug fixes but may not be a big problem as it
just avoids duplicate code. If you and others want we can back this
now or otherwise, we can do it later if we really see the difficulty
later.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-03 14:02:23 | Re: pgsql: Add wait_for_subscription_sync for TAP tests. |
| Previous Message | Alvaro Herrera | 2022-08-03 10:45:44 | Re: pgsql: Add wait_for_subscription_sync for TAP tests. |