| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2023-12-26 10:05:02 |
| Message-ID: | CAA4eK1+Y4KVBOdJ0UWPzHUUvJMVYZbbnRrhwxFN4gyqJ0dfO8A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 26, 2023 at 3:00 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > I think we should be able to detect it if we want but do we want to
> > add this restriction considering that users can always install the
> > required plugins after standby gets promoted? I think we can do either
> > way in this case but as we are not going to use these slots till the
> > standby node is promoted, it seems okay to validate the plugins after
> > promotion once users use the synced slots.
>
> Personally it should be detected, but I want to hear opinions from others.
> Below are my reasons:
>
> 1)
> We can avoid a possibility that users miss the installation of plugins. Basically
> we should detect before the issue will really occur.
>
> 2)
> Rules around here might be inconsistent. Slots which will be synchronized can be
> created either way:
>
> a) manual creation via SQL function, or
> b) automatic creation by slotsync worker.
>
> In case of a), the decoding context is created when creation so that the plugin
> must be installed. Case b), however, we allow not to install beforehand. I felt
> it might be confused for users. Thought?
>
I think the (a) way could lead to the setting of incorrect LSNs
(restart_LSN and confirmed_flush_lsn) considering they are not copied
from the primary.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2023-12-26 10:10:36 | Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work |
| Previous Message | Michael Paquier | 2023-12-26 10:04:53 | Re: pg_basebackup has an accidentaly separated help message |