From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Ordering of header file inclusion |
Date: | 2019-11-23 05:53:26 |
Message-ID: | CAA4eK1+X9bxv32q2j_it8GzLbFQbYdVre+LH=N7+=9Cn1F=taQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 22, 2019 at 8:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> vignesh C <vignesh21(at)gmail(dot)com> writes:
> > After the inclusion they have define and further include based on #if
> > defined. In few cases I had seen the include happens at the end of the
> > file like in regcomp.c as there may be impact. I felt it is better not
> > to change these files. Let me know your thoughts on the same.
>
> I think the point of this patch series is just to make cosmetic
> adjustments in places where people have randomly failed to maintain
> alphabetic order of a consecutive group of #include's. Messing with
> examples like the above is way out of scope, if you ask me --- it
> entails more analysis, and more risk of breakage, than a purely
> cosmetic goal is worth.
>
+1. I agree with what Tom said, so let's leave such things as it is.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tels | 2019-11-23 08:13:21 | Re: backup manifests |
Previous Message | Ranier Vilela | 2019-11-23 03:38:23 | RE: [BUG] (firsttupleslot)==NULL is redundant or is possible null dereference? |