| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | cleanup in code |
| Date: | 2014-01-04 05:20:02 |
| Message-ID: | CAA4eK1+Vk5z6V=xsKHsw9_0US=LbgE6i-GksEvSyqNX59zuZRg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
1. compiling with msvc shows warning in relcache.c
1>e:\workspace\postgresql\master\postgresql\src\backend\utils\cache\relcache.c(3959):
warning C4715: 'RelationGetIndexAttrBitmap' : not all control paths
return a value
Attached patch remove_msvc_warning.patch to remove above warning
2. It seems option K is not used in pg_dump:
while ((c = getopt_long(argc, argv,
"abcCd:E:f:F:h:ij:K:n:N:oOp:RsS:t:T:U:vwWxZ:",
long_options, &optindex)) != -1)
I have checked both docs and code but didn't find the use of this option.
Am I missing something here?
Attached patch remove_redundant_option_K_pgdump.patch to remove this option
from code.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| remove_msvc_warning.patch | application/octet-stream | 406 bytes |
| remove_redundant_option_K_pgdump.patch | application/octet-stream | 447 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | knizhnik | 2014-01-04 07:46:25 | Re: [ANNOUNCE] IMCS: In Memory Columnar Store for PostgreSQL |
| Previous Message | Peter Geoghegan | 2014-01-04 03:48:47 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |